Conversation
Signed-off-by: xermicus <cyrill@parity.io>
xermicus
added
R0-no-crate-publish-required
Member
Author
|
bot fmt |
|
@xermicus https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/7940391 was started for your command Comment |
|
@xermicus Command |
Member
Author
|
/cmd prdoc --audience runtime_dev --bump minor |
Member
Author
|
/cmd bench --runtime dev --pallet pallet_revive |
Contributor
|
Command "bench --runtime dev --pallet pallet_revive" has started 🚀 See logs here |
4 tasks
Contributor
|
Command "bench --runtime dev --pallet pallet_revive" has finished ✅ See logs here DetailsSubweight results:
Command output:✅ Successful benchmarks of runtimes/pallets: |
Member
Why? Isn't this a balance value which could theoretically exceed u64? |
Member
Author
Ah yes of course - I just short-circuited it because the gas price is currently |
Signed-off-by: xermicus <cyrill@parity.io>
Signed-off-by: xermicus <cyrill@parity.io>
Member
Author
|
/cmd bench --runtime dev --pallet pallet_revive |
Contributor
|
Command "bench --runtime dev --pallet pallet_revive" has started 🚀 See logs here |
Member
Strictly speaking it is capped to u128 which is our balance type everywhere. But it is a generic type. And in these cases we exposed it as u256 in all other places. |
Member
Author
|
@athei yes I fully agree. |
Contributor
|
Command "bench --runtime dev --pallet pallet_revive" has finished ✅ See logs here DetailsSubweight results:
Command output:✅ Successful benchmarks of runtimes/pallets: |
|
All GitHub workflows were cancelled due to failure one of the required jobs. |
jarkkojs
reviewed
Dec 19, 2024
| // you may not use this file except in compliance with the License. | ||
| // You may obtain a copy of the License at | ||
| // | ||
| // http://www.apache.org/licenses/LICENSE-2.0 |
Contributor
There was a problem hiding this comment.
Not demanding to remove this in principle SPDX already fixes this up, and rest is redundant information.
Member
There was a problem hiding this comment.
If we want to change the header it needs to be a separate PR changing headers in all files.
jarkkojs
approved these changes
Dec 19, 2024
athei
approved these changes
Dec 19, 2024
| // you may not use this file except in compliance with the License. | ||
| // You may obtain a copy of the License at | ||
| // | ||
| // http://www.apache.org/licenses/LICENSE-2.0 |
Member
There was a problem hiding this comment.
If we want to change the header it needs to be a separate PR changing headers in all files.
dudo50
pushed a commit
to paraspell-research/polkadot-sdk
that referenced
this pull request
Jan 4, 2025
This PR implements the base fee syscall API method. Currently this is implemented as a compile time constant in the revive compiler, returning 0. However, since this is an opocde, if we ever need to implement it for compatibility reasons with [EIP-1559](https://github.com/ethereum/EIPs/blob/master/EIPS/eip-1559.md), it would break already deployed contracts. Thus we provide a syscall method instead. --------- Signed-off-by: xermicus <cyrill@parity.io> Signed-off-by: Cyrill Leutwiler <bigcyrill@hotmail.com> Co-authored-by: command-bot <>
7 tasks
This was referenced Jul 16, 2025
github-project-automation
Bot
moved this from Todo
to Done
in [preview] release tracker
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR implements the base fee syscall API method. Currently this is implemented as a compile time constant in the revive compiler, returning 0. However, since this is an opocde, if we ever need to implement it for compatibility reasons with EIP-1559, it would break already deployed contracts. Thus we provide a syscall method instead.